Re: win32mak_patch

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: win32mak_patch
Date: 2008-04-27 17:00:26
Message-ID: 005901c8a888$30aecd80$0b01a8c0@yourc3ftrhkaod
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi.

Eh? It is strange...
http://winpg.jp/~saito/pg_work/WIN32_BUILD_INF/psql_win32.mak
Actually, it is required although psql is built. Have I missed something?

Regards,
Hiroshi Saito

----- Original Message -----
From: "Magnus Hagander" <magnus(at)hagander(dot)net>

> The changes except the one to exports.txt look ok.
>
> Why do you need to export pgwin32_safestat? It's *not* exported when
> you build with mingw or the automated msvc build, and nothing breaks
> there. Who is trying to use it?
>
> //Magnus
>
> Hiroshi Saito wrote:
>> Hi.
>>
>> Oops, Certainly.
>> I propose the method of merging by distprep as exports.txt.win32.
>> What do you think?
>>
>> Regards,
>> Hiroshi Saito
>>
>> ----- Original Message -----
>> From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>>
>>
>> > "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
>> >> *** src/interfaces/libpq/exports.txt.orig Sun Apr 27 23:41:51 2008
>> >> --- src/interfaces/libpq/exports.txt Sun Apr 27 23:42:48 2008
>> >> ***************
>> >> *** 141,143 ****
>> >> --- 141,144 ----
>> >> pg_valid_server_encoding_id 139
>> >> PQconnectionNeedsPassword 140
>> >> lo_import_with_oid 141
>> >> + pgwin32_safestat 142
>> >
>> >
>> > We are most certainly NOT doing that (for one reason, it will
>> > instantly break every platform except Windows). If there is
>> > something that seems to require it then you need to find another
>> > way.
>> >
>> > regards, tom lane
>>
>> --
>> Sent via pgsql-patches mailing list (pgsql-patches(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-patches
>
>
> --
> Sent via pgsql-patches mailing list (pgsql-patches(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-patches

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Albe Laurenz 2008-04-28 06:57:51 Re: Improve shutdown during online backup, take 4
Previous Message Magnus Hagander 2008-04-27 16:49:40 Re: win32mak_patch