cnfify() performance

From: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
To: "pgsql-hackers" <pgsql-hackers(at)postgreSQL(dot)org>
Subject: cnfify() performance
Date: 1999-07-22 01:47:30
Message-ID: 000001bed3e4$28c8b900$2801007e@cadzone.tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

A question about TODO item
* Fix memory exhaustion when using many OR's

pull_ors() and pull_ands() are called while processing
cnfify() and both call copyObject().
^^^^^^^^^^^^^^
For example in pull_ors()

return (pull_ors(nconc(copyObject((Node *) args),
copyObject((Node *) lnext(orlist)))));

copyObject() seems too heavy
Is copyObject() necessary in this case ?
Couldn't we change as below ?

return (pull_ors(nconc(listCopy(args),
listCopy( lnext(orlist)))));

I'm not sure it's possible or not ,because I don't understand
cnfify() and other related stuff.

If it's possible,it would improve cnfify()'s performance and
memory consumption in many OR's cases ,though it would
never fix TODO item.

Comments ?

Regards.

Hiroshi Inoue
Inoue(at)tpf(dot)co(dot)jp

Browse pgsql-hackers by date

  From Date Subject
Next Message Vince Vielhaber 1999-07-22 01:48:57 RE: [HACKERS] Re: [BUGS] Dropped connection during COPY causes t
Previous Message Ryan Kirkpatrick 1999-07-22 01:39:06 Re: [PORTS] RedHat6.0 & Alpha