| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel WM <dwilches(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16293: postgres segfaults and returns SQLSTATE 08006 |
| Date: | 2020-03-31 09:37:56 |
| Message-ID: | CA+HiwqH_4dnZ=9gqKYk8fkECkB00pCYeXttiZLtjxFr7T8LYew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Mar 31, 2020 at 3:30 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Tue, Mar 24, 2020 at 3:53 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > If we actually want to keep this conversion, I wonder if the right
> > answer would be to change those routines to pass in
> > mtstate->mt_root_tuple_slot instead (and ensure it's created when
> > needed). One way to achieve that would be to move
> > ModifyTableState->mt_root_tuple_slot to ResultRelInfo - and potentially
> > create it on demand?
>
> Something like ri_PartitionRootSlot sounds like a good idea, but we
> should make that a reference to mt_root_tuple_slot instead of its
> replacement. Would you be interested in seeing a patch?
I have updated the patch for HEAD to be this way.
--
Thank you,
Amit Langote
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Build-root-tuple-in-ExecBuildSlotValueDescription.patch | application/octet-stream | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-31 13:43:36 | Re: BUG #16330: psql accesses null pointer in connect.c:do_connect |
| Previous Message | Michael Paquier | 2020-03-31 07:21:53 | Re: BUG #16330: psql accesses null pointer in connect.c:do_connect |