Re: [HACKERS] BUG #14825: enum type: unsafe use?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Christophe Pettus <christophe(dot)pettus(at)pgexperts(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] BUG #14825: enum type: unsafe use?
Date: 2017-09-27 18:52:54
Message-ID: 10135.1506538374@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> At this stage on reflection I agree it should be pulled :-(

That seems to be the consensus, so I'll go make it happen.

> I'm not happy about the idea of marking an input function as not
> parallel safe, certainly not without a good deal of thought and
> discussion that we don't have time for this cycle.

I think the way forward is to do what we had as of HEAD (984c92074),
but add the ability to transmit the blacklist table to parallel
workers. Since we expect the blacklist table would be empty most of
the time, this should be close to no overhead in practice. I concur
that the idea of marking the relevant functions parallel-restricted is
probably not as safe a fix as I originally thought, and it's not a
very desirable restriction even if it did fix the problem.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message harisankar.valiyattil 2017-09-27 20:59:33 BUG #14831: Intermittent write blocks
Previous Message Tom Lane 2017-09-27 14:39:59 Re: [HACKERS] Float value 'Infinity' is cast to numeric 1 on Windows

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2017-09-27 18:55:57 Re: list of credits for release notes
Previous Message Peter Eisentraut 2017-09-27 18:47:45 list of credits for release notes