From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image |
Date: | 2010-04-26 12:57:25 |
Message-ID: | z2s937d27e11004260557zb2d27a1cu654bbc936b1fc978@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Rats - hit send to soon.
One final issue - the Save Image option is only letting me save bitmap
image files. Any chance of JPEG/PNG as well? PNG would be the
preferred format and should be the default.
On Mon, Apr 26, 2010 at 1:48 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi Ashesh,
>
> On Fri, Apr 23, 2010 at 10:44 PM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>> PFA
>
> OK, this patch now compiles on the Mac. I think here are a few things
> that need work
>
> - The Save/Print options are not enabled when they should be. For
> example, if I open the query tool, and run an Explain, I have to click
> to the 'Data Output' tab and then back to the Explain tab before the
> Save/Print options get enabled.
>
> - Why are there separate options for Saving/Printing the EXPLAIN
> output and GQB? As only one can be displayed at a time, we should have
> just one set of options which apply to the visible image.
>
> - The borders on saved images seem somewhat arbitrary. It would be
> good to crop the image to a consistent border around the visible items
> (say 25 or 50 pixels for example).
>
> - If you click on a node in a plan and then save the image, the popup
> info box isn't included.
>
> FYI, I don't think the last two items are essential to fix before beta
> 1. The first two are though.
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise Postgres Company
>
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2010-04-26 13:01:08 | Re: PATCH: Ticket#99: Support for Default Privileges |
Previous Message | Dave Page | 2010-04-26 12:48:32 | Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image |