Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Streaming replication document improvements

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-docs(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Streaming replication document improvements
Date: 2010-04-21 17:29:15
Message-ID: y2w603c8f071004211029ge9824bccse3dcdb76a1c6f693@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-docspgsql-hackers
On Wed, Apr 21, 2010 at 12:20 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Thanks for the heads up.  It doesn't look hard to put a similar test
>> in the walsender code path, but is there any reason to duplicate the
>> code?  Seems like we might be able to just put this test (with the
>> necessary modification) right before this comment:
>
> Hm, actually I think you're right: we could move both of those
> connection-rejecting tests up to before the walsender exit.  The

I am guessing that by "both of those connection-rejecting tests", you
mean the one that can throw "must be superuser to connect during
database shutdown" as well as the one we were discussing, which can
throw "connection limit exceeded for non-superusers", in which case...

> only extra state we need is ReservedBackends, which should be valid
> at that point (in particular, it can't be affected by any process-local
> GUC settings).
>
> +1 for just moving the test.

...shouldn't we move the "tests", plural, rather than just the one?
It seems right to reject new SR connections during shutdown.

...Robert

In response to

Responses

pgsql-docs by date

Next:From: Tom LaneDate: 2010-04-21 17:56:03
Subject: Re: [HACKERS] Streaming replication document improvements
Previous:From: Tom LaneDate: 2010-04-21 16:20:59
Subject: Re: [HACKERS] Streaming replication document improvements

pgsql-hackers by date

Next:From: Jehan-Guillaume (ioguix) de RorthaisDate: 2010-04-21 17:40:42
Subject: Re: [RFC] nodeToString format and exporting the SQL parser
Previous:From: Simon RiggsDate: 2010-04-21 16:32:26
Subject: Re: Move tablespace

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group