Skip site navigation (1) Skip section navigation (2)

Re: Issues with my patch on the groups of servers

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Issues with my patch on the groups of servers
Date: 2010-04-26 10:01:01
Message-ID: y2t937d27e11004260301jb64d9009g71c511957175f6b6@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Apr 26, 2010 at 10:51 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Hi,
>
> While working on the connection combobox for frmQuery, I found some
> rather amusing (or not) bugs in my patch for groups of servers. It seems
> there are quite a few use of the browser that don't like groups. pgAdmin
> doesn't crash, but is not more able to discover servers. Take
> dlgSelectConnection for example. It doesn't crash pgAdmin, but a user
> can't select a new connection because the dialog doesn't find servers
> and disables server and database comboboxes. And I think other
> components will be hit by this.
>
> There is surely simple fixes for them. Problem is: I'm not sure I'll
> have the time to work on those. It could be I will, but I'm simply not sure.
>
> So, I'm a bit hesitant on what to do. I could revert my previous patch,
> and push it in once it's clearly good... but it could be good enought,
> one day after the release of beta 1. I could also try to fix the issues
> (I don't think they are that many), but what should we do if I can't
> have a good enough behaviour when beta 1 will be wrapped up?
>
> I'm actually working on these bugs. So I kind of prefer #2. Any strong
> opinion on this?

I prefer 2 as well. It's not the end of the world if beta 1 isn't
perfect though, as long it's it's not completely broken.


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-04-26 11:03:30
Subject: Re: PATCH: Ticket#99: Support for Default Privileges
Previous:From: Guillaume LelargeDate: 2010-04-26 09:51:15
Subject: Issues with my patch on the groups of servers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group