Skip site navigation (1) Skip section navigation (2)

Re: PATCH: Ticket#99: Support for Default Privileges

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Ticket#99: Support for Default Privileges
Date: 2010-04-27 12:58:58
Message-ID: y2j937d27e11004270558rdb6ea910hb30a5627abe50701@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Apr 27, 2010 at 10:02 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave,
> Please find the updated patch.
> It has all the changes - as you suggested.

Close - but not quite there :-)

- The listview that lists the privileges is still a fixed height, and
on Mac, it pushes the TRIGGER privilege below the bottom of the
control area. Please see the two attached screenshots. If you make the
listview the variable height component (as it is on the privileges
tab, it'll make sizing work properly.

- The listview columns are still too small by default, as can be seen
in the screenshot. Compare them to the sizes of the equivalent columns
on the 'Privileges' tab.

- TABLES, SEQUENCES and FUNCTIONS are still in upper case, and not init-capped.

- The labels in the properties list view shouldn't have each work
init-capped (and we can shorten them a little) - eg. "Default
Privileges On Tables" should be "Default table ACL" (we use ACL
already in the list).

- There is no blank line between the table definition and the first
ALTER DEFAULT... statement in the SQL pane, eg.:

=====
CREATE DATABASE postgres
  WITH OWNER = postgres
       ENCODING = 'UTF8'
       TABLESPACE = pg_default
       LC_COLLATE = 'C'
       LC_CTYPE = 'C'
       CONNECTION LIMIT = -1;
ALTER DEFAULT PRIVILEGES
    GRANT INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES,
TRIGGER ON TABLES
    TO postgres;

ALTER DEFAULT PRIVILEGES
    GRANT INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES,
TRIGGER ON TABLES
    TO public;

ALTER DEFAULT PRIVILEGES
    GRANT SELECT, UPDATE, USAGE ON SEQUENCES
    TO postgres;
=====

Otherwise, it's looks like it's now working as expected :-)

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-04-27 15:43:39
Subject: Re: PATCH: Ticket#99: Support for Default Privileges
Previous:From: svnDate: 2010-04-27 12:25:47
Subject: SVN Commit by guillaume: r8302 - in trunk/pgadmin3/pgadmin: . ctl dlg frm schema

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group