Skip site navigation (1) Skip section navigation (2)

Re: PATCH: Ticket#99: Support for Default Privileges

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Ticket#99: Support for Default Privileges
Date: 2010-04-26 13:01:08
Message-ID: w2x8cf965d31004260601w5cfdeb28z267b3ceeb3417021@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Dave,

On Mon, Apr 26, 2010 at 4:33 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>wrote:

> Hi Ashesh
>
> On Fri, Apr 23, 2010 at 10:27 PM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Please find the updated patch.
> >
>
> OK, this builds now. I still see a few issues that need resolving though:
>
> - The layout needs some work - see the attached screenshot. On the
> Tables tab, the listview doesn't have any space, yet there's a blank
> area at the bottom (I guess it needs to be made the expandable row in
> the layout grid).
>
ok.

>
> - The only place we should be using all caps is for the permissions
> names. The 'PRIVILEGES ON', 'TABLES', 'SEQUENCES', 'FUNCTIONS' should
> all be init-capped. The default permission for 'PUBLIC' should be
> 'public', per the existing permissions tabs.
>
> - The label by the combo box should say 'Role' not 'Group'.
>
> - The column widths in the listview need more appropriately sizing.
>
Right.


>
> - In some cases, if I click the Add button without selecting a Role, I
> get a row added to the listview with an icon but no text. In others, I
> get a crash.
>
:-(. Never experience..
I will look more into into..

>
> - Default ACLs aren't reverse engineered and shown in the SQL pane for
> databases or schemas.
>
Will do.

>
> - Default ACLs aren't shown in the Properties dialog for Databases
> (seems to work for Schemas, though I couldn't check the Tables tab).
>
It should be available for the existing objects, not for new object creation
for the database.

>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise Postgres Company
>

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2010-04-26 13:03:44
Subject: Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image
Previous:From: Dave PageDate: 2010-04-26 12:57:25
Subject: Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group