From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Re: pgsql: Make CheckRequiredParameterValues() depend upon correct |
Date: | 2010-04-23 21:27:21 |
Message-ID: | w2v603c8f071004231427q68843521q676b82007db9c352@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Apr 23, 2010 at 4:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> No intention of doing that. This change allows people to see what the
>> dependency actually is once the bug has been fixed. Change needs to
>> start from here, not from where we were before.
>
> Well, actually, now that I've looked at the patch I think it's starting
> from a fundamentally wrong position anyway. Checkpoint records are a
> completely wrong mechanism for transmitting this data to slaves, because
> a checkpoint is emitted *after* we do something, not *before* we do it.
> In particular it's ludicrous to be looking at shutdown checkpoints to
> try to determine whether the subsequent WAL will meet the slave's
> requirements. There's no connection at all between what the GUC state
> was at shutdown and what it might be after starting again.
>
> A design that might work is
> (1) store the active value of wal_mode in pg_control (but NOT as part of
> the last-checkpoint-record image).
> (2) invent a new WAL record type that is transmitted when we change
> wal_mode.
Well, right now wal_mode would only be able to be changed at server
restart. Eventually we might relax that, but I think there are some
restrictions on how we can do it - like maybe needing to wait until
all the transactions running at the time the change was decided on
have committed, or, well, I'm not sure.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2010-04-23 21:32:13 | Re: [HACKERS] Re: pgsql: Make CheckRequiredParameterValues() depend upon correct |
Previous Message | Tom Lane | 2010-04-23 20:44:41 | Re: [HACKERS] Re: pgsql: Make CheckRequiredParameterValues() depend upon correct |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-04-23 21:29:09 | Re: recovery_connections cannot start (was Re: master in standby mode croaks) |
Previous Message | Simon Riggs | 2010-04-23 21:26:55 | Re: recovery_connections cannot start (was Re: master in standby mode croaks) |