Skip site navigation (1) Skip section navigation (2)

Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image
Date: 2010-04-26 13:03:44
Message-ID: u2r8cf965d31004260603q1a26f8fbpf679add98ee5a21d@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Apr 26, 2010 at 6:27 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Rats - hit send to soon.
>
> One final issue - the Save Image option is only letting me save bitmap
> image files. Any chance of JPEG/PNG as well? PNG would be the
> preferred format and should be the default.
>
Should be possible, but don't remember as I worked on this long back.
The current patch is just refactored patch  from the older patch.

--
Ashesh

>
> On Mon, Apr 26, 2010 at 1:48 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> > Hi Ashesh,
> >
> > On Fri, Apr 23, 2010 at 10:44 PM, Ashesh Vashi
> > <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> >> PFA
> >
> > OK, this patch now compiles on the Mac. I think here are a few things
> > that need work
> >
> > - The Save/Print options are not enabled when they should be. For
> > example, if I open the query tool, and run an Explain, I have to click
> > to the 'Data Output' tab and then back to the Explain tab before the
> > Save/Print options get enabled.
> >
> > - Why are there separate options for Saving/Printing the EXPLAIN
> > output and GQB? As only one can be displayed at a time, we should have
> > just one set of options which apply to the visible image.
> >
> > - The borders on saved images seem somewhat arbitrary. It would be
> > good to crop the image to a consistent border around the visible items
> > (say 25 or 50 pixels for example).
> >
> > - If you click on a node in a plan and then save the image, the popup
> > info box isn't included.
> >
> > FYI, I don't think the last two items are essential to fix before beta
> > 1. The first two are though.
> >
> > --
> > Dave Page
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise Postgres Company
> >
>
>
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise Postgres Company
>

In response to

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-04-26 13:08:18
Subject: Re: PATCH: Ticket#99: Support for Default Privileges
Previous:From: Ashesh VashiDate: 2010-04-26 13:01:08
Subject: Re: PATCH: Ticket#99: Support for Default Privileges

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group