Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive

From: Andrew - Supernews <andrew+nonews(at)supernews(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive
Date: 2005-08-01 02:39:42
Message-ID: slrnder2re.bj3.andrew+nonews@trinity.supernews.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 2005-07-31, Oliver Jowett <oliver(at)opencloud(dot)com> wrote:
> I'm not worried about changing values; I think that representing the
> "option level" as an IP protocol number, in an interface that
> encompasses non-IP protocols, is a bad API design decision.

The interpretation of that parameter, if not equal to SOL_SOCKET, is
clearly protocol-dependent and therefore driven by the protocol family of
the socket.

> If the rule for setsockopt is "pass the IP protocol number as the  level
> argument", then what value should I pass to manipulate, say,
> X.25-specific settings on an X.25 socket?

The rule is "pass whatever value the socket's protocol family expects".
For IP that happens to be an IP protocol number. For other families it
is some constant meaningful to that family.

> In practice you use a synthetic value which is outside the range of
> valid IP protocols.

No, you don't. There is no assumption that socket level parameters form
a single namespace (with the exception of SOL_SOCKET which is common to
all protocol families).

> getprotoent() won't know about this value

getprotoent() is specific to the INET address family and makes no attempt
to pretend to support anything else (if it did, it'd need to take an AF_*
parameter to disambiguate between families).

>> Also, that assignment is not mere BSD-ism, it's specified by the Single
>> Unix Spec, as well as every other document I could lay my hands on
>> today.  Whoever wrote the comments in linux/socket.h is just
>> clueless.
>
> That seems a bit unfair, the comment is accurate (the SOL_* constants do
> need to match the protocol number assignments for compatibility with
> code that expects the BSD behaviour) and might even predate SUS.

It's based on a fundamental misunderstanding that SOL_* constants other than
SOL_SOCKET should even exist and that they form a namespace (which they do
not).

-- 
Andrew, Supernews
http://www.supernews.com - individual and corporate NNTP services

In response to

Responses

pgsql-hackers by date

Next:From: Oliver JowettDate: 2005-08-01 03:24:09
Subject: Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive
Previous:From: Bruce MomjianDate: 2005-08-01 02:26:27
Subject: Re: [HACKERS] For review: Server instrumentation patch

pgsql-committers by date

Next:From: Oliver JowettDate: 2005-08-01 03:24:09
Subject: Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive
Previous:From: Bruce MomjianDate: 2005-08-01 00:52:28
Subject: pgsql: Add description: < This would require a new global table that

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group