Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] docs toolchain appears broke?

From: Ian Lance Taylor <ian(at)airs(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL Hackers List <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] docs toolchain appears broke?
Date: 2001-03-26 07:04:53
Message-ID: siy9ttdn8q.fsf@daffy.airs.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Larry Rosenman <ler(at)lerctr(dot)org> writes:
> > gmake[1]: Leaving directory `/home/ler/pg-dev/pgsql/doc/src/sgml'
> > cd sgml && tar -cf ../programmer.tar --exclude=Makefile
> > --exclude='*.sgml' --exclude=ref *.html -C `cd . && pwd`/graphics
> > catalogs.gif connections.gif
> > tar: can't add file catalogs.gif : No such file or directory
> > tar: can't add file connections.gif : No such file or directory
> > gmake: *** [programmer.tar] Error 1
> 
> Kinda looks like Ian broke the compile-in-source-dir case while
> making the compile-in-separate-dir case work.  Tut tut.

Yes.  My apologies.  This patch is one way to fix things.

Ian

Index: Makefile
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/Makefile,v
retrieving revision 1.17
diff -u -r1.17 Makefile
--- Makefile	2001/03/25 08:32:24	1.17
+++ Makefile	2001/03/26 07:03:23
@@ -43,17 +43,20 @@
 programmer.tar:
 	$(MAKE) -C sgml clean
 	$(MAKE) -C sgml programmer.html
-	cd sgml && $(TAR) -cf ../$@ $(TAREXCLUDE) *.html -C `cd $(srcdir) && pwd`/graphics catalogs.gif connections.gif
+	abssrcdir=`cd $(srcdir) && pwd`; \
+	cd sgml && $(TAR) -cf ../$@ $(TAREXCLUDE) *.html -C $$abssrcdir/graphics catalogs.gif connections.gif
 
 tutorial.tar:
 	$(MAKE) -C sgml clean
 	$(MAKE) -C sgml tutorial.html
-	cd sgml && $(TAR) -cf ../$@ $(TAREXCLUDE) *.html -C `cd $(srcdir) && pwd`/graphics clientserver.gif
+	abssrcdir=`cd $(srcdir) && pwd`; \
+	cd sgml && $(TAR) -cf ../$@ $(TAREXCLUDE) *.html -C $$abssrcdir/graphics clientserver.gif
 
 postgres.tar:
 	$(MAKE) -C sgml clean
 	$(MAKE) -C sgml postgres.html
-	cd sgml && $(TAR) -cf ../$@ $(TAREXCLUDE) *.html -C `cd $(srcdir) && pwd`/graphics catalogs.gif clientserver.gif connections.gif
+	abssrcdir=`cd $(srcdir) && pwd`; \
+	cd sgml && $(TAR) -cf ../$@ $(TAREXCLUDE) *.html -C $$abssrcdir/graphics catalogs.gif clientserver.gif connections.gif
 
 man.tar:
 	$(MAKE) -C sgml man

In response to

Responses

pgsql-hackers by date

Next:From: Zeugswetter Andreas SBDate: 2001-03-26 10:44:56
Subject: AW: AW: AW: Re: RELEASE STOPPER? nonportable int64 constant s in pg_crc.c
Previous:From: Adriaan JoubertDate: 2001-03-26 06:24:36
Subject: Re: Call for platforms

pgsql-patches by date

Next:From: Magnus HaganderDate: 2001-03-26 09:16:07
Subject: RC1 on Native Win32 - patch required
Previous:From: Tom LaneDate: 2001-03-26 06:15:02
Subject: Re: docs toolchain appears broke?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group