Skip site navigation (1) Skip section navigation (2)

Re: PATCH: Ticket#99: Support for Default Privileges

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Ticket#99: Support for Default Privileges
Date: 2010-04-27 16:52:17
Message-ID: s2t8cf965d31004270952h31c198ccwa50d823ed76463ae@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Dave,

PFA the updated patch.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>


On Tue, Apr 27, 2010 at 6:28 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Tue, Apr 27, 2010 at 10:02 AM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> > Please find the updated patch.
> > It has all the changes - as you suggested.
>
> Close - but not quite there :-)
>
> - The listview that lists the privileges is still a fixed height, and
> on Mac, it pushes the TRIGGER privilege below the bottom of the
> control area. Please see the two attached screenshots. If you make the
> listview the variable height component (as it is on the privileges
> tab, it'll make sizing work properly.
>
> - The listview columns are still too small by default, as can be seen
> in the screenshot. Compare them to the sizes of the equivalent columns
> on the 'Privileges' tab.
>
> - TABLES, SEQUENCES and FUNCTIONS are still in upper case, and not
> init-capped.
>
> - The labels in the properties list view shouldn't have each work
> init-capped (and we can shorten them a little) - eg. "Default
> Privileges On Tables" should be "Default table ACL" (we use ACL
> already in the list).
>
> - There is no blank line between the table definition and the first
> ALTER DEFAULT... statement in the SQL pane, eg.:
>
> =====
> CREATE DATABASE postgres
>  WITH OWNER = postgres
>       ENCODING = 'UTF8'
>       TABLESPACE = pg_default
>       LC_COLLATE = 'C'
>       LC_CTYPE = 'C'
>       CONNECTION LIMIT = -1;
> ALTER DEFAULT PRIVILEGES
>    GRANT INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES,
> TRIGGER ON TABLES
>    TO postgres;
>
> ALTER DEFAULT PRIVILEGES
>    GRANT INSERT, SELECT, UPDATE, DELETE, TRUNCATE, REFERENCES,
> TRIGGER ON TABLES
>    TO public;
>
> ALTER DEFAULT PRIVILEGES
>    GRANT SELECT, UPDATE, USAGE ON SEQUENCES
>    TO postgres;
> =====
>
> Otherwise, it's looks like it's now working as expected :-)
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise Postgres Company
>

Attachment: Ticket99_v6_1.patch
Description: text/x-patch (83.4 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2010-04-27 19:16:47
Subject: SVN Commit by dpage: r8303 - in trunk/pgadmin3: . pgadmin pgadmin/ctl pgadmin/dlg pgadmin/include/ctl pgadmin/include/dlg pgadmin/include/schema pgadmin/schema pgadmin/ui
Previous:From: Dave PageDate: 2010-04-27 15:43:39
Subject: Re: PATCH: Ticket#99: Support for Default Privileges

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group