| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Joe Conway <mail(at)joeconway(dot)com> |
| Subject: | Re: walreceiver is uninterruptible on win32 |
| Date: | 2010-04-16 07:03:36 |
| Message-ID: | s2k3f0b79eb1004160003ndc57ccebr729ffd9c3f42eb57@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 15, 2010 at 11:26 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I have to admit to finding this confusing. According to the comments:
>
> + /*
> + * Don't emulate the PQexec()'s behavior of returning the last
> + * result when there are many, since walreceiver never sends a
> + * query returning multiple results.
> + */
>
> ...but it looks like the code actually is implementing some sort of
> loop-that-returns-the-last result.
Yeah, it's not a very accurate description. And I found another problem:
libpqrcv_PQexec() ends as soon as an error result arrives even if its
state has not been PGASYNC_IDLE yet.
So I changed libpqrcv_PQexec() so that it emulates the PQexec()'s behavior
except the concatenation of error messages. How about the attached patch?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| libpqrcv_PQexec_v4.patch | application/octet-stream | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2010-04-16 07:37:55 | Re: pgindent and tabs in comments |
| Previous Message | Bob Lunney | 2010-04-16 03:11:47 | Re: [PATCH] Add --ordered option to pg_dump |