On Sun, Apr 11, 2010 at 10:36 PM, Guillaume Lelarge
> I have an almost working patch. I still have one bug: if someone adds
> the first server in a group, the group and the server don't appear in
> the treeview. After quite some tests and debugging, the program adds
> them in the treeview, but after the CreateObjects call, they disappear.
I didn't see that here. It seemed to work fine - though it sure would
be nice if it would dynamically move the nodes around. Restarting
pgAdmin to see the changes doesn't feel nice. It also feels like I
should be able to right-click a group node, though I appreciate you
cannot do that with the Servers node either.
Finally (I think!) - it seems weird that the Servers node lists the
total number of Servers, even those that aren't direct children.
Y'know - as I type I can't help thinking that the correct way to do
this is to consider the root node to be the group, in which we
currently have a single, fixed group called 'Servers'. Additional
groups would then be additional root nodes... but I don't know if you
can do that on all operating systems.
> BTW, it is not the final patch, some work remain to be done (the group
> combobox is only used as a textbox right now, it's badly displayed, some
> code are redundant, etc.)
Yeah, I saw that.
BTW - I noticed another issue while I was there. The default colour
shown by the colour select button seems to be random, so for servers
for which I never previously chose a colour updating them to set a
group is also changing them to a random colour, unless I manually
choose that too.
EnterpriseDB UK: http://www.enterprisedb.com
In response to
pgadmin-hackers by date
|Next:||From: svn||Date: 2010-04-15 21:46:32|
|Subject: SVN Commit by guillaume: r8267 - in branches/REL-1_10_0_PATCHES/pgadmin3: . pgadmin/dlg pgadmin/frm pgadmin/gqb pgadmin/include/dlg pgadmin/include/gqb|
|Previous:||From: Guillaume Lelarge||Date: 2010-04-11 21:36:41|
|Subject: Ticket 3: groups of servers|