Skip site navigation (1) Skip section navigation (2)

Re: pending patch: Re: HS/SR and smart shutdown

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pending patch: Re: HS/SR and smart shutdown
Date: 2010-03-31 03:10:18
Message-ID: p2q603c8f071003302010hb8e72d53rd8eb763ac9735912@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Tue, Mar 30, 2010 at 9:48 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Mar 31, 2010 at 9:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Mar 30, 2010 at 5:09 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> I rebased the patch to HEAD. Is the patch still required for 9.0?
>>> If not, I'd remove the open item of the smart shutdown during
>>> recovery.
>>
>> I am by no means an expert on this area of the code, but in the
>> interest of moving things along I reviewed this patch tonight.
>
> Thanks a lot!
>
>> 1. I wonder if there is a problem if we receive SIGINT while in the
>> PM_WAIT_READONLY state?  Seems to me that might need to be added to
>> the if statement beginning at line 2212, in pmdie().
>>
>> 2. It appears to me that HandleChildCrash() needs to switch to
>> PM_WAIT_BACKENDS state if it's in PM_WAIT_READONLY when the child
>> crash occurs - i.e. the if statement beginning at line 2772 needs
>> updating.
>>
>> Thoughts?
>
> Oh, those are my oversights. You are right!
> I modified the patch as you pointed out.

Cool.  This looks good to me now and I also tested it.  I will commit
it unless (a) someone objects or (b) someone else does it first.

...Robert

In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-03-31 03:21:42
Subject: Re: Parameter name standby_mode
Previous:From: Robert HaasDate: 2010-03-31 03:06:16
Subject: sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group