Skip site navigation (1) Skip section navigation (2)

Re: Materialized views WIP patch

From: "Marko Tiikkaja" <pgmail(at)joh(dot)to>
To: "Kevin Grittner" <kgrittn(at)mail(dot)com>
Cc: "Pgsql Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Materialized views WIP patch
Date: 2012-12-02 23:24:48
Message-ID: op.woppzmjfye4vw9@blue.lan (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi Kevin,

On Mon, 26 Nov 2012 22:24:33 +0100, Kevin Grittner <kgrittn(at)mail(dot)com>  
wrote:
> Marko Tiikkaja wrote:
>> <T2 sees an empty table>
>
> As far as I know you are the first to notice this behavior. Thanks
> for pointing it out.
>
> I will take a look at the issue; I don't know whether it's
> something small I can address in this CF or whether it will need to
> be in the next CF, but I will fix it.

Any news on this front?

>> I'll get back when I manage to get a better grasp of the code.

The code looks relatively straightforward and good to my eyes.  It passes  
my testing and looks to be changing all the necessary parts of the code.

> Keep in mind that the current behavior of behaving like a regular
> view when the contents are invalid is not what I had in mind, that
> was an accidental effect of commenting out the body of the
> ExecCheckRelationsValid() function right before posting the patch
> because I noticed a regression. When I noticed current behavior, it
> struck me that someone might prefer it to the intended behavior of
> showing an error like this:
>
>   ereport(ERROR,
>     (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
>      errmsg("materialized view \"%s\" has not been populated",
>             get_rel_name(rte->relid)),
>      errhint("Use the LOAD MATERIALIZED VIEW command.")));
>
> I mention it in case someone wants to argue for silently behaving
> as a regular view when the MV is not populated.

FWIW, I'd prefer an error in this case, but I don't feel strongly about it.


Regards,
Marko Tiikkaja


In response to

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2012-12-03 00:50:11
Subject: Re: Tablespaces in the data directory
Previous:From: Andrew DunstanDate: 2012-12-02 22:30:53
Subject: pgsql: Add mode where contrib installcheck runs each module in asepara

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group