Skip site navigation (1) Skip section navigation (2)

Re: Query tool execute to file prompting

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Query tool execute to file prompting
Date: 2010-03-31 10:01:36
Message-ID: o2o937d27e11003310301oa5a963d1s6a8667fd5ea21694@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Mar 30, 2010 at 4:34 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Hi!
>
> This patch attempts to address the issue that at least I've heard a
> couple of time, of that the "execute to file" feature doesn't prompt
> for the filename until after it's finished. This is quite annoying
> when running multi-hour queries.

Looks sane.

> Other than a review please, I couldn't find where we actually destroy
> the QueryExecInfo object allocated in frmQuery::execQuery(). It gets
> picked up in OnQueryComplete(), but I don't see a delete anywhere. Is
> it automatically deleted by the wx stuff (in which case I have a leak
> of qi->toFileExportForm that I have to take care of), or do we have a
> leak there today (in which case I have that leak to take care of :D).

It sure looks like a leak to me. Seems like we should delete it after
the call to completeQuery. Not sure if that will leave a leak if the
query is aborted though.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-04-01 22:54:29
Subject: Re: Rework of the frmOptions window
Previous:From: Magnus HaganderDate: 2010-03-30 15:34:59
Subject: Query tool execute to file prompting

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group