Re: New acinclude.m4

----Message d'origine----
>Copie à: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>,
>De: Adam H.Pendleton <fmonkey(at)fmonkey(dot)net>
>Sujet: Re: [pgadmin-hackers] New acinclude.m4
>Date: Thu, 19 May 2005 13:14:47 -0400
>A: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
>
>Yes. Nice catch.

A small one compared to the work you did!

The new acinclude.m4 works like a charm even with wxWid --flavour and even on pgAdmin REL-1_2_0_PATCHES branch.
Do you think to any problem including it in 1.2.x branch apart from the fact that you invoke 'ogl' which is not required for 1.2.2 but does not harm the 1.2.x build ?

Regards,
Raphaël

>
>On May 19, 2005, at 1:07 PM, Raphaël Enrici wrote:
>
>
>> Dave Page wrote:
>>
>>
>>>
>>>
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: pgadmin-hackers-owner(at)postgresql(dot)org
>>>> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
>>>> Adam H. Pendleton
>>>> Sent: 18 May 2005 22:26
>>>> To: pgadmin-hackers(at)postgresql(dot)org
>>>> Subject: [pgadmin-hackers] New acinclude.m4
>>>>
>>>> Attached is a new acinclude.m4, and a patch to our current
>>>> acinclude,
>>>> that relies on wx-config for all the flags. Gone is all the
>>>> complicated stuff. The only thing this new acinclude doesn't do is
>>>> warn about a missing stc or ogl. It will link against them,
>>>> but if a
>>>> user doesn't have them, their compile will fail. I'll be adding in
>>>> stub programs to test for this in my next version. In the meantime,
>>>> test and enjoy.
>>>>
>>>>
>>>
>>>
>>> Great, thanks Adam - committed.
>>>
>>>
>>
>>
>> I have warning concerning ENABLE_STATIC in configure script. Shouldn't
>> we also remove it crom configure.ac ? (patch attached).
>>
>> Regards,
>> Raphaël
>> Index: configure.ac
>> ===================================================================
>> --- configure.ac (revision 4219)
>> +++ configure.ac (working copy)
>> @@ -35,7 +35,6 @@
>> CHECK_WX_CONFIG_BINARY
>> CHECK_PGSQL_INCLUDE
>> ENABLE_DEBUG
>> -ENABLE_STATIC
>> CHECK_PGSQL
>> CHECK_WXWINDOWS
>>
>>
>>
>
>
>
>---------------------------(end of broadcast)---------------------------
>TIP 7: don't forget to increase your free space map settings
>