From:
Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: Command Triggers, patch v11
Date:
2012-02-27 21:22:03
Message-ID:
m24nucvuo4.fsf@2ndQuadrant.fr (view raw or flat )
Thread:
2012-02-24 22:04:17 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-24 22:32:35 from Thom Brown <thom(at)linux(dot)com>
2012-02-24 22:39:08 from Thom Brown <thom(at)linux(dot)com>
2012-02-24 23:01:54 from Thom Brown <thom(at)linux(dot)com>
2012-02-24 23:43:40 from Thom Brown <thom(at)linux(dot)com>
2012-02-25 11:58:56 from Thom Brown <thom(at)linux(dot)com>
2012-02-27 19:37:09 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-28 11:43:54 from Thom Brown <thom(at)linux(dot)com>
2012-02-28 13:32:09 from Thom Brown <thom(at)linux(dot)com>
2012-02-28 15:03:57 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-02-28 15:09:01 from "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
2012-03-03 00:12:46 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-03 13:45:10 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-03 14:03:01 from Thom Brown <thom(at)linux(dot)com>
2012-03-03 14:34:59 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-03 15:55:35 from Thom Brown <thom(at)linux(dot)com>
2012-02-28 15:14:29 from Thom Brown <thom(at)linux(dot)com>
2012-03-02 22:32:16 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-02 23:33:41 from Thom Brown <thom(at)linux(dot)com>
2012-03-03 00:08:33 from Thom Brown <thom(at)linux(dot)com>
2012-03-03 00:39:13 from "anarazel(at)anarazel(dot)de" <andres(at)anarazel(dot)de>
2012-03-03 00:56:12 from Thom Brown <thom(at)linux(dot)com>
2012-03-03 14:26:28 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-03 15:37:02 from Thom Brown <thom(at)linux(dot)com>
2012-03-04 15:50:39 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-05 00:33:11 from Thom Brown <thom(at)linux(dot)com>
2012-03-05 20:42:00 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-05 21:10:37 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-05 21:33:13 from Thom Brown <thom(at)linux(dot)com>
2012-03-06 21:04:31 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-06 21:18:58 from Thom Brown <thom(at)linux(dot)com>
2012-03-06 23:25:55 from Thom Brown <thom(at)linux(dot)com>
2012-03-07 21:53:35 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 14:09:29 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-09 14:22:51 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 14:30:14 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-09 14:35:17 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 14:47:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-09 15:02:56 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 17:51:00 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-09 19:16:25 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-09 15:05:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-09 15:09:04 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 15:29:31 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-09 17:29:55 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-08 22:24:22 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-09 00:28:08 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 11:53:38 from Thom Brown <thom(at)linux(dot)com>
2012-03-09 21:38:53 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-09 22:42:49 from Thom Brown <thom(at)linux(dot)com>
2012-03-16 20:54:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-16 21:07:23 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-16 21:31:57 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-16 21:37:38 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-16 21:52:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-16 22:17:43 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-17 15:02:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-17 17:45:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-17 18:16:26 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-17 22:04:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-17 22:26:53 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-18 18:29:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-18 19:12:03 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-19 01:11:06 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-19 13:13:26 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-19 16:35:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-19 16:45:11 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-19 16:52:00 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-18 21:47:47 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-03-19 01:16:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-19 16:53:21 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-03-19 17:06:25 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-19 18:10:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-19 18:51:29 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-20 01:39:56 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-03-20 15:55:33 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-20 17:44:40 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-25 12:00:53 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-25 12:07:36 from Thom Brown <thom(at)linux(dot)com>
2012-02-25 12:42:00 from Thom Brown <thom(at)linux(dot)com>
2012-02-25 13:15:51 from Thom Brown <thom(at)linux(dot)com>
2012-02-25 13:28:15 from Thom Brown <thom(at)linux(dot)com>
2012-02-25 14:30:26 from Thom Brown <thom(at)linux(dot)com>
2012-02-25 16:36:41 from Thom Brown <thom(at)linux(dot)com>
2012-02-26 00:07:47 from Thom Brown <thom(at)linux(dot)com>
2012-02-26 14:12:43 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-26 19:49:12 from Thom Brown <thom(at)linux(dot)com>
2012-02-26 23:24:31 from Thom Brown <thom(at)linux(dot)com>
2012-02-27 19:31:45 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-27 20:53:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-02-27 21:22:03 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-04 18:08:18 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-27 19:19:44 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-27 19:19:13 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-02-27 19:30:31 from Thom Brown <thom(at)linux(dot)com>
2012-02-27 19:37:24 from Andres Freund <andres(at)anarazel(dot)de>
2012-02-27 23:32:26 from Andres Freund <andres(at)anarazel(dot)de>
2012-02-28 00:21:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-02-28 00:29:20 from "anarazel(at)anarazel(dot)de" <andres(at)anarazel(dot)de>
2012-03-13 11:22:26 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-13 15:14:06 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2012-03-13 20:07:32 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-13 21:06:46 from Andres Freund <andres(at)anarazel(dot)de>
2012-03-14 03:41:39 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-14 08:27:08 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-14 12:56:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-03-14 21:33:28 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-03-15 12:03:03 from Thom Brown <thom(at)linux(dot)com>
2012-03-15 14:52:23 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Lists:
pgsql-hackers
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> FWIW, I agree with Thom on this. If we do it as you suggest, I
> confidently predict that it will be less than a year before we seriously
> regret it. Given all the discussion around this, it's borderline insane
> to believe that the set of parameters to be passed to command triggers
> is nailed down and won't need to change in the future.
I agree with the analysis…
> As for special coding of support, it hardly seems onerous when every
> language that has triggers at all has got some provision for the
> existing trigger parameters. A bit of copying and pasting should get
> the job done.
But had been (too easily) convinced not to take that route. You changed
my mind already, I'll see about changing the code too tomorrow (a cold
is having me out of steam for tonight).
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
In response to
pgsql-hackers by date
Next :From: Greg SmithDate: 2012-02-27 21:41:43
Subject : Re: pgstat documentation tables
Previous :From : Tom LaneDate : 2012-02-27 20:53:58
Subject : Re: Command Triggers, patch v11