From: | Rene Pijlman <rene(at)lab(dot)applinet(dot)nl> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Cc: | Barry Lind <barry(at)xythos(dot)com>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-jdbc(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jeroen(dot)van(dot)vianen(at)satama(dot)com |
Subject: | Re: [HACKERS] JDBC pg_description update needed for CVS tip |
Date: | 2001-09-08 22:18:05 |
Message-ID: | j24lpt424poqf3oj681diaue1ffl07fgal@4ax.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc pgsql-patches |
On Fri, 07 Sep 2001 01:34:46 -0400, Tom Lane wrote:
>there is still an unpatched reference to pg_description in
>getColumns(), in both jdbc1 and jdbc2.
This was introduced by Jeroen's patch (see
http://fts.postgresql.org/db/mw/msg.html?mid=1032468). Attached
is a patch that returns getColumns() to using "select
obj_description()" instead of direct access to pg_description,
as per the request by Tom.
I've incorporated Jeroen's fix to left outer join with
pg_attrdef instead of inner join, so getColumns() also returns
columns without a default value.
I have, however, not included Jeroen's attempt to combine
multiple queries into one huge multi-join query for better
performance, because:
1) I don't know how to do that using obj_description() instead
of direct access to pg_description
2) I don't think a performance improvement (if any) in this
method is very important
Because of the outer join, getColumns() will only work with a
backend >= 7.1. Since the conditional coding for 7.1/7.2 and
jdbc1/jdbc2 is already giving me headaches I didn't pursue a
pre-7.1 solution.
Regards,
René Pijlman <rene(at)lab(dot)applinet(dot)nl>
Attachment | Content-Type | Size |
---|---|---|
patchGetColumns.diff | text/plain | 19.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2001-09-08 23:25:49 | Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT.... |
Previous Message | Ian Lance Taylor | 2001-09-08 21:21:04 | Problem with new anoncvs server |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Weis | 2001-09-08 22:38:03 | getBlob problems with bytea type columns |
Previous Message | Rene Pijlman | 2001-09-08 14:16:04 | Fix JDBC test suite, set/get transaction isolation level test in ConnectionTest |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-09-08 22:31:23 | Re: Support building in a different directory on Solaris |
Previous Message | Gavin Sherry | 2001-09-08 16:39:35 | Re: attribute names & typecast/psql default port |