Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image

Please find the updated patch.

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>

On Thu, Apr 22, 2010 at 10:18 PM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Thu, Apr 22, 2010 at 9:48 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Thu, Apr 22, 2010 at 4:57 PM, Ashesh Vashi
>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>> > Yeah..
>> > It does require only in gtk.. (linux)
>> > "--enable-printarch --with-gnomeprint"...
>> > And, It requires "libgnomeprint" package to be installed on development
>> > machine...
>>
>> That's a potential problem - we're at the mercy of the packagers on
>> most OS's and they may not have configured wxWidgets correctly for our
>> needs.
>>
>> I think we need to make the printing feature conditional on whether
>> wxWidgets has been compiled appropriately, which probably needs a
>> configure test. If support for printing isn't there, then it needs to
>> build pgAdmin without those options.
>>
>
> One of the reason, I have used macro wxUSE_PRINTING_ARCHITECTURE provided
> by the wxWidgets.
>
>
>> Also - I noticed near the top of the patch that there were a few
>> strings that looked translatable which were wrapped in _T(). That
>> should be _() for translatable strings, or wxT() for non-translatable.
>>
> Sure.
> I will send the updated patch.
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>
>
>
>> --
>> Dave Page
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise Postgres Company
>>
>
>