Re: PATCH: Ticket#99: Support for Default Privileges

Hi Ashesh

On Fri, Apr 23, 2010 at 10:27 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Please find the updated patch.
>

OK, this builds now. I still see a few issues that need resolving though:

- The layout needs some work - see the attached screenshot. On the
Tables tab, the listview doesn't have any space, yet there's a blank
area at the bottom (I guess it needs to be made the expandable row in
the layout grid).

- The only place we should be using all caps is for the permissions
names. The 'PRIVILEGES ON', 'TABLES', 'SEQUENCES', 'FUNCTIONS' should
all be init-capped. The default permission for 'PUBLIC' should be
'public', per the existing permissions tabs.

- The label by the combo box should say 'Role' not 'Group'.

- The column widths in the listview need more appropriately sizing.

- In some cases, if I click the Add button without selecting a Role, I
get a row added to the listview with an icon but no text. In others, I
get a crash.

- Default ACLs aren't reverse engineered and shown in the SQL pane for
databases or schemas.

- Default ACLs aren't shown in the Properties dialog for Databases
(seems to work for Schemas, though I couldn't check the Tables tab).

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company