Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

From: Jasen Betts <jasen(at)xnet(dot)co(dot)nz>
To: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Date: 2010-06-11 10:47:13
Message-ID: hut47h$p8q$2@reversiblemaps.ath.cx
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2010-06-10, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Jun 10, 2010 at 9:02 AM, Stefan Kaltenbrunner
><stefan(at)kaltenbrunner(dot)cc> wrote:
>> I for myself would be rather annoyed if we started quoting all column names
>> in our dumps. This is seriously hampering readability and while it is
>> already annoying that pg_dump output is slightly different from the original
>> DDL used this would make it far worse.
>
> It's only been proposed to make it an option, not to shove it down
> anyone's throat.
>
> Given Tom's comments upthread, I suspect that much of this will come
> down to whether anyone feels like trying to put in the work to make
> this happen, and whether they can come up with a reasonably clean
> design that doesn't involve massive code changes. Having not studied
> the problem, I don't have an opinion on whether that's possible.
>
> I do agree that the human readability of pg_dump is an asset in many
> situations - I have often dumped out the DDL for particular objects
> just to look at it, for example. However, I emphatically do NOT agree
> that leaving someone with a 500MB dump file (or, for some people on
> this list, a whole heck of a lot larger than that) that has to be
> manually edited to reload is a useful behavior. It's a huge pain in
> the neck.

Don't edit manually, use sed instead.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Jasen Betts 2010-06-11 11:30:33 Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Previous Message Bruce Momjian 2010-06-10 23:15:49 Re: Invalid YAML output from EXPLAIN