Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] [HACKERS] Bug on pg_lesslog

From: Koichi Suzuki <koichi(dot)szk(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org, jd(at)commandprompt(dot)com
Subject: Re: [GENERAL] [HACKERS] Bug on pg_lesslog
Date: 2010-02-11 22:49:03
Message-ID: ef4f49ae1002111449m3c07ca5eocf7f5435406d1290@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-generalpgsql-hackers
In addition, in the fix, I'm thinking I should add at least the
following check mechanism;

1. Check XNOOP record size to match the original WAL record.
2. Restore WAL segment at the time of pg_compress, compare restored
WAL with the original and check it is safe to use in the restoration,
both each WAL record and whole WAL segment.

----------
Koichi Suzuki



2010/2/12 Koichi Suzuki <koichi(dot)szk(at)gmail(dot)com>:
> Thank you very much for the advice.   Yes I think it should go to
> announce.   I will post a message.
> ----------
> Koichi Suzuki
>
>
>
> 2010/2/12 Karl Denninger <karl(at)denninger(dot)net>:
>> Joshua D. Drake wrote:
>>
>> On Thu, 2010-02-11 at 23:39 +0900, Koichi Suzuki wrote:
>>
>>
>> Dear Folks;
>>
>> A very serious bug was reported on pg_lesslog.   So far, I found it's
>> a bug in pg_compresslog.   Please do not use pg_compresslog and
>> pg_decompresslog until improved version is uploaded.
>>
>> I strongly advise to take base backup of your database.
>>
>> I apologize for inconvenience.   I'll upload the new version ASAP.
>>
>>
>> Should this go out on announce?
>>
>>
>> I certainly think so.  Anyone who gets caught "by surprise" on this could
>> quite possibly lose all their data!
>>
>> I (fortunately) caught it during TESTING of my archives - before I needed
>> them.
>>
>> -- Karl Denninger
>>
>>
>

In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-02-11 23:59:13
Subject: Re: log_error_verbosity function display
Previous:From: Bruce MomjianDate: 2010-02-11 22:47:35
Subject: Re: log_error_verbosity function display

pgsql-bugs by date

Next:From: Robert HaasDate: 2010-02-12 03:47:10
Subject: Re: BUG #5323: plperl and plperlu interaction segfaults
Previous:From: Koichi SuzukiDate: 2010-02-11 22:39:23
Subject: Re: [GENERAL] [HACKERS] Bug on pg_lesslog

pgsql-general by date

Next:From: GreenhornDate: 2010-02-11 22:53:52
Subject: left join count
Previous:From: Koichi SuzukiDate: 2010-02-11 22:39:23
Subject: Re: [GENERAL] [HACKERS] Bug on pg_lesslog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group