Skip site navigation (1) Skip section navigation (2)

Re: Incorrect "invalid AM/PM string" error from to_timestamp

From: "Joshua Tolley" <eggyknap(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Brendan Jurd" <direvus(at)gmail(dot)com>, "Alex Hunsaker" <badalex(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Incorrect "invalid AM/PM string" error from to_timestamp
Date: 2008-09-26 14:15:15
Message-ID: e7e0a2570809260715t2ac3d737md8497b33f84d192c@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugs
On Fri, Sep 26, 2008 at 8:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Brendan Jurd" <direvus(at)gmail(dot)com> writes:
>> I have some thoughts on this and other issues surrounding AM/PM, but
>> perhaps they are better reserved for a separate thread.  Might I
>> suggest we apply Alex's bugfix and hold off on the message changes
>> pending further discussion?
>
> Agreed on separating the message issue.  What I wanted to know was
> whether there are similar bugs elsewhere in to_timestamp, or whether
> you're pretty sure this is the only occurrence of the coding pattern?
> I've always found it helpful to think "where else did we make this
> same mistake" after identifying a bug.
>
>                        regards, tom lane
>

I guess we know this already, but for the sake of trying to appear
involved, I've confirmed this fixes the problem as I was seeing it. +1
for the message being a bit more specific, though it's a definite
improvement as is.

- Josh

PS> My apologies for sending this directly to Tom instead of to the
list the first time I sent it.

In response to

pgsql-bugs by date

Next:From: Brendan JurdDate: 2008-09-26 14:35:26
Subject: Re: Incorrect "invalid AM/PM string" error from to_timestamp
Previous:From: Tom LaneDate: 2008-09-26 14:11:19
Subject: Re: Incorrect "invalid AM/PM string" error from to_timestamp

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group