Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Unicode escapes in E'...' strings Author: Marko Kreen

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Unicode escapes in E'...' strings Author: Marko Kreen
Date: 2009-09-26 19:17:39
Message-ID: e51f66da0909261217j4ee21169q2aa33d40fda93bfc@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Resend...

On 9/26/09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Marko Kreen <markokr(at)gmail(dot)com> writes:
>  > On 9/26/09, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
> >> That patch results in the following message from flex:
>  >>
>  >> psqlscan.l:1039: warning, -s option given but default rule can be
>  >> matched
>
>  > Agh.  Well, that just means the <xeu> state must be commented out:
>
>  >  -%x xeu
>  >  +/* %x xeu */
>
>
> Ick --- that breaks the whole concept of keeping the two sets of
>  flex rules in sync.  And it's quite unclear why it fixes the problem,
>  too.  At the very least, if you do it that way, it needs a comment
>  explaining exactly why it's different from the backend.

The commenting-out fixes the problem, because I copy pasted the state
declaration without any rules in it.

Anyway, now I attached a patch, where I filled the section but without
referring it from anywhere.  The rules itself are now equal.  Is that OK?

-- 
marko

Attachment: psql-unicode2.diff
Description: text/x-diff (1.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Josh BerkusDate: 2009-09-26 19:33:06
Subject: Re: Hot Standby on git
Previous:From: Dan ColishDate: 2009-09-26 18:28:59
Subject: Re: Hot Standby on git

pgsql-committers by date

Next:From: Tom LaneDate: 2009-09-26 22:42:03
Subject: pgsql: Extend the BKI infrastructure to allow system catalogs to be
Previous:From: Tom LaneDate: 2009-09-26 18:25:36
Subject: pgsql: Fix RelationCacheInitializePhase2 (Phase3, in HEAD) to cope with

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group