Re: BUG #4731: compile with -fast fails on ld: duplicate symbol _PGP_S2K_TYPE in pgp.o and pgp-mpi-openssl.o

On 3/25/09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Ceriel Jacobs" <cerieljacobs(at)gmail(dot)com> writes:
> > ld: duplicate symbol _PGP_S2K_TYPE in pgp.o and pgp-mpi-openssl.o
>
> I think at bottom that's a compiler/linker bug which you should mention
> to Apple. However, I see what is causing it: pgp.h contains
>
> enum
> {
> PGP_S2K_SIMPLE = 0,
> PGP_S2K_SALTED = 1,
> PGP_S2K_ISALTED = 3
> } PGP_S2K_TYPE;
>
> I think what was meant was
>
> enum PGP_S2K_TYPE
> {
> PGP_S2K_SIMPLE = 0,
> PGP_S2K_SALTED = 1,
> PGP_S2K_ISALTED = 3
> };
>
> because what the first one is doing is defining a global variable
> that is of an anonymous enum type.

Eh, it's silly mistake indeed.

> Marko, am I right that this is just a syntax mistake, and not
> intentional creation of a variable? There are several occurrences
> of the pattern in pgp.h.

Yes, it's syntax bug. Should I send patch?

--
marko