[bugfix] DISCARD ALL does not release advisory locks

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Postgres Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: [bugfix] DISCARD ALL does not release advisory locks
Date: 2008-11-24 15:07:04
Message-ID: e51f66da0811240707l7af1ea4fg1058ae8a94bf9fe0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

It was brought to my attention that DISCARD ALL
does not release advisory locks:

http://pgfoundry.org/tracker/index.php?func=detail&aid=1010499&group_id=1000258&atid=983

Thus connection managers / poolers need to do that manually.

This obviously means DISCARD ALL needs fixing. Applied
patch adds LockReleaseAll(USER_LOCKMETHOD, true) call
to DiscardAll().

Should this also be fixed in 8.3?

--
marko

Attachment Content-Type Size
discard_advisory_locks.diff text/x-patch 676 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-24 15:08:44 Re: [bugfix] DISCARD ALL does not release advisory locks
Previous Message Robert Haas 2008-11-24 15:04:01 Re: blatantly a bug in the documentation