Skip site navigation (1) Skip section navigation (2)

review: table function support

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Postgres Hackers" <pgsql-hackers(at)postgresql(dot)org>
Cc: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
Subject: review: table function support
Date: 2008-07-09 11:05:03
Message-ID: e51f66da0807090405gd5ad4c3h892986181cf09d7a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Generally, the patch looks fine.  There are few issues still:

- plpgsql: the result columns _do_ create local variables.
  AIUI, they should not?

- pg_dump: is the psql_assert() introduction necessary, considering it
  is used only in one place?

- There should be regression test for plpgsql too, that test if
  the behaviour is correct.

- The documentation should mention behaviour difference from OUT
  parameters.

Wishlist (probably out of scope for this patch):

- plpgsql: a way to create record variable for result row.  Something like:

    CREATE FUNCTION foo(..) RETURNS TABLE (..) AS $$
    DECLARE
       retval   foo%ROWTYPE;


  Currently the OUT parameters are quite painful to use due to bad
  name resolving logic.  Such feature would be perfect replacement.

-- 
marko

Responses

pgsql-hackers by date

Next:From: Marko KreenDate: 2008-07-09 11:22:45
Subject: Re: Auto-explain patch
Previous:From: Tino WildenhainDate: 2008-07-09 10:32:18
Subject: Re: Identifier case folding notes

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2008-07-09 11:54:08
Subject: Re: page macros cleanup (ver 04)
Previous:From: Alvaro HerreraDate: 2008-07-09 01:28:34
Subject: Re: [PATCHES] WITH RECURSIVE updated to CVS TIP

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group