On 11/23/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > On 11/23/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Why? I can't imagine any real use for it. If you're thinking that
> >> it could provide a guide as to what to resize the buffer to, think
> >> again.
> > If the output was truncated due to this limit then the return
> > value is the number of characters (not including the trailing
> > '\0') which would have been written to the final string if
> > enough space had been available.
> > What problem do you see?
> The problem is that you are quoting from some particular system's
> manual, and not any kind of standard ... much less any standard that
> every platform we support follows.
> The real-world situation is that we are lucky to be able to tell
> vsnprintf success from failure at all :-(
I just saw the result used inside the function, so I thought
it is standard enough.
Actually, the meaning could be changed to *needmore
and compensated inside function:
*needmore = (nprinted < buf->maxlen) ? buf->maxlen : nprinted + 1;
Then it would not matter if libc is conforming or not.
In response to
pgsql-patches by date
|Next:||From: Marko Kreen||Date: 2007-11-23 09:55:22|
|Subject: Cleaner API for appendStringInfoVA|
|Previous:||From: Tom Lane||Date: 2007-11-23 07:46:36|
|Subject: Re: plpython crash on exception |