Skip site navigation (1) Skip section navigation (2)

Re: txid strtoull fix

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: txid strtoull fix
Date: 2007-10-08 20:51:28
Message-ID: e51f66da0710081351l5083e34cp6c1cd770df4f439@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-patches
On 10/8/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > I noticed strtoull() causes problems on some buildfarm
> > machines.  As a fix I propose small str2num function inside
> > txid.c itself.  Main reason is that the txid actually does
> > not need fully-featured strtoull (radixes, whitespace skipping).
>
> Seems like a sane solution to me --- applied.
>
> (Note that your overflow test didn't actually work; AFAIK there
> really isn't any decent solution other than dividing at each step.)

Hmm.  It did seem to work here.  Just in case I peeked into
FreeBSD strtoull() and this patch imitates their method.

This also seems to work, but please review, I'm don't feel
very sharp anymore...

-- 
marko

Attachment: txid.overflow.diff
Description: application/octet-stream (1.2 KB)

In response to

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2007-10-08 20:53:20
Subject: Re: [HACKERS] Add function forquote_qualified_identifier?
Previous:From: Tom LaneDate: 2007-10-08 20:27:29
Subject: Re: txid strtoull fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group