Re: [PATCH] Have configure complain about unknown options

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Have configure complain about unknown options
Date: 2006-05-05 11:22:25
Message-ID: e51f66da0605050422v17ed8fb0qf81fe682ec5de762@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On 5/4/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> > Currently, configure ignores unknown --enable/disable/with/without
> > options.
>
> The autoconf people consider that a feature, not a bug. I'm
> disinclined to second-guess the designers of the tool, especially
> with a patch like this that mucks with the internals to the extent that
> it'll probably break in every future autoconf revision.
>
> Feel free to try to convince them to change it though ...

AFAIK that 'feature' is there to support configuring a 'tree'
of projects (like gcc), where subprojects have their own configure
scripts with different options. That way you can give all options
to top-level configure script which passes them to other scripts and
each picks only whats needed. In such setting all scripts need to
ignore unknown options.

As PostgreSQL tree is not set up that way, I think for clarity sake
it would be better to give explicit errors for unknown options.

--
marko

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-05-05 11:39:46 Re: [PATCH] Have configure complain about unknown options
Previous Message Heikki Linnakangas 2006-05-05 06:28:26 Re: Page at a time index scan