Skip site navigation (1) Skip section navigation (2)

Re: xpath_array with namespaces support

From: "Nikolay Samokhvalov" <samokhvalov(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: xpath_array with namespaces support
Date: 2007-04-10 12:01:28
Message-ID: e431ff4c0704100501m6a41adcaw47fe07dfe606c846@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-patches
Here is new version that adds following changes:
  4. Function is now strict, per discussion.
  5. Return empty array in case when XPath expression detects nothing
(previously, NULL was returned in such case), per discussion.
  6. (bugfix) Work with fragments with prologue: select xpath('/a',
'<?xml version="1.0"?><a /><b />'); // now XML datum is always wrapped
with dummy <x>...</x>, XML prologue simply goes away (if any).
  7. Some cleanup.

On 4/4/07, Nikolay Samokhvalov <nikolay(at)samokhvalov(dot)com> wrote:
> The patch attached contains following changes:
>    1. The function name xmlpath() is changed to xpath();
>    2. Approach of passing of namepspace mappings to the function is changed:
> now that array (the 3rd argument) should be a 2-dimentional array with the
> length of the second axis = 2 (e.g., ARRAY[ARRAY['a1', 'http://a1'],
> ARRAY['a2', 'http://a2'], ARRAY['a2', 'http://a2']]);
>    3. Description of xpath() function in docs (I'm sorry for possible
> mistakes in English and docbook formatting, please check it...)
>
>
> On 4/3/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Nikolay Samokhvalov wrote:
> > > On 3/22/07, Peter Eisentraut < peter_e(at)gmx(dot)net> wrote:
> > > > Bruce Momjian wrote:
> > > > > Patch applied.
> > > >
> > > > This code seems to think that if an xml datum starts with "<?xml" it's
> a
> > > > document.  That is completely bogus.
> > >
> > > Agreed. I'll fix it.
> >
> > Nikolay, it has been a week, and I have see no fixes from you in
> > response to requests from Peter.  If the patch doesn't arrive in 1-2
> > days, I will have to revert your patch and it will be kept for 8.4.
> > Feature freeze was April 1, 2007.
> >
> > --
> >   Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
> >   EnterpriseDB
> http://www.enterprisedb.com
> >
> >   + If your life is a hard drive, Christ can be your backup. +
> >
>
>
>
> --
> Best regards,
> Nikolay
>


-- 
Best regards,
Nikolay

Attachment: xpath.fixes.20070410.patch
Description: text/x-patch (18.2 KB)

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-04-10 13:17:48
Subject: Re: xpath_array with namespaces support
Previous:From: ITAGAKI TakahiroDate: 2007-04-10 11:46:54
Subject: Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group