Re: xpath_array with namespaces support

From: "Nikolay Samokhvalov" <samokhvalov(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: xpath_array with namespaces support
Date: 2007-04-08 17:34:47
Message-ID: e431ff4c0704081034x38d841f4o2f5b4493f38c6734@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

I've realized that Peter's criticism (concerning comparing beginning
of datum with "<?xml") is right: current approach is unable to work
with XML values such as "<?xml ...?><a /><b />".

I'll propose a modification of the patch as long as fixes for NULLs as
input and output values very soon (in a day or so).

On 4/4/07, Nikolay Samokhvalov <nikolay(at)samokhvalov(dot)com> wrote:
> The patch attached contains following changes:
> 1. The function name xmlpath() is changed to xpath();
> 2. Approach of passing of namepspace mappings to the function is changed:
> now that array (the 3rd argument) should be a 2-dimentional array with the
> length of the second axis = 2 (e.g., ARRAY[ARRAY['a1', 'http://a1'],
> ARRAY['a2', 'http://a2'], ARRAY['a2', 'http://a2']]);
> 3. Description of xpath() function in docs (I'm sorry for possible
> mistakes in English and docbook formatting, please check it...)
>
>
> On 4/3/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Nikolay Samokhvalov wrote:
> > > On 3/22/07, Peter Eisentraut < peter_e(at)gmx(dot)net> wrote:
> > > > Bruce Momjian wrote:
> > > > > Patch applied.
> > > >
> > > > This code seems to think that if an xml datum starts with "<?xml" it's
> a
> > > > document. That is completely bogus.
> > >
> > > Agreed. I'll fix it.
> >
> > Nikolay, it has been a week, and I have see no fixes from you in
> > response to requests from Peter. If the patch doesn't arrive in 1-2
> > days, I will have to revert your patch and it will be kept for 8.4.
> > Feature freeze was April 1, 2007.
> >
> > --
> > Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> > EnterpriseDB
> http://www.enterprisedb.com
> >
> > + If your life is a hard drive, Christ can be your backup. +
> >
>
>
>
> --
> Best regards,
> Nikolay
>

--
Best regards,
Nikolay

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2007-04-08 19:34:53 Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries
Previous Message Simon Riggs 2007-04-08 16:02:08 Re: Reviewers Guide to DeferredTransactions/TransactionGuarantee