2010/1/26 Peter Eisentraut <peter_e(at)gmx(dot)net>:
> On tis, 2010-01-19 at 01:01 +0900, Hitoshi Harada wrote:
>> I reviewed this patch today.
>
> Thank you for this very thorough and helpful review.  Comments below and
> a new patch attached.
>
OK, I confirmed all the issues relevant to the patch were fixed. I'm
not so familiar with transaction detail, so I leave it as a known
issue.

I found ereport() in MergeAttributes() should be indented but except
for that there's no issue. So I think I've done my review.

> I have a follow-up patch that I haven't been able to finish that adds
> ALTER TYPE stuff to do add/dropping/renaming on the type.  I will submit
> it once we get this patch finalized and I find some time.

I'll look at it when it's ready.

Regards,


-- 
Hitoshi Harada

In response to

• Re: Review: Typed Table at 2010-01-25 19:45:25 from Peter Eisentraut

Responses

• Re: Review: Typed Table at 2010-01-28 23:22:03 from Peter Eisentraut

pgsql-hackers by date

Next:	From: Alvaro Herrera	Date: 2010-01-27 15:53:11
	Subject: Re: C function accepting/returning cstring vs. text
Previous:	From: Tom Lane	Date: 2010-01-27 15:43:04
	Subject: Re: Patch: psql \whoami option