| From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: More frame options in window functions |
| Date: | 2010-01-19 20:02:16 |
| Message-ID: | e08cc0401001191202w2e706fe9q8faed1d9b2a8cc13@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2010/1/19 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> Yeah, that's my point, too. The planner has to distinguish "four" from
> sort pathkeys and to teach the executor the simple information which
> column should be used to determine frame. I was bit wrong because some
> of current executor code isn't like it, like using ordNumCols == 0 to
> know whether partition equals to frame, though....
And here's another version to fix this problem (I hope). Now the
planner distinguish sort column from actual significant pathkeys. I
tested it on both of 32bit and 64bit Linux.
Regards,
--
Hitoshi Harada
| Attachment | Content-Type | Size |
|---|---|---|
| more_frame_options.20100120.patch.gz | application/x-gzip | 24.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-01-19 20:06:06 | Re: attoptions |
| Previous Message | Robert Haas | 2010-01-19 20:01:40 | Re: quoting psql varible as identifier |