Skip site navigation (1) Skip section navigation (2)

Re: review: More frame options in window functions

From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: More frame options in window functions
Date: 2010-01-14 18:32:32
Message-ID: e08cc0401001141032n6b5d6dd7ke548d4debbf9c8a6@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/1/14 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
> Hello
>
> I looked on Hitoshi's patch - and my result is:

Thanks for the review. I've found another crash today and attached is
fixed version. The case is:

SELECT four, sum(ten) over (PARTITION BY four ORDER BY four RANGE 1
PRECEDING) FROM tenk1 WHERE unique1 < 10;

The planner recognizes windowagg->ordNumCol as 0 for optimization, but
RANGE offset cases should really have interest on that value as the
syntax says.

Regards,


-- 
Hitoshi Harada

Attachment: more_frame_options.20100115.patch.gz
Description: application/x-gzip (23.9 KB)

In response to

pgsql-hackers by date

Next:From: David FetterDate: 2010-01-14 18:36:09
Subject: Re: mailing list archiver chewing patches
Previous:From: Tom LaneDate: 2010-01-14 18:11:23
Subject: Re: Clearing global statistics

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group