Re: IntArray in c.h

2009/12/30 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
>> I found the struct IntArray defined in c.h is actually used only in
>> execQual.c. ISTM the definition should be at least moved to the right
>> place.
>
> It's a general-purpose datatype that might be used anywhere that array
> indexing happens.  I think the fact that it's currently used only in
> execQual is mere happenstance, and should not be "enforced" by moving
> or removing the declaration.

I would be convinced if the struct or the logic was complex, but
actually it is so simple that it can be replaced by primitive int
array. Also, it seems to me that c.h is too general place to declare
it for such purpose. Does nobody else think so?

Regards,

--
Hitoshi Harada