Skip site navigation (1) Skip section navigation (2)

Re: Windowing Function Patch Review -> Standard Conformance

From: "Hitoshi Harada" <umi(dot)tanuki(at)gmail(dot)com>
To: "Vladimir Sitnikov" <sitnikov(dot)vladimir(at)gmail(dot)com>
Cc: "David Rowley" <dgrowley(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, heikki(dot)linnakangas(at)enterprisedb(dot)com
Subject: Re: Windowing Function Patch Review -> Standard Conformance
Date: 2008-11-07 15:46:47
Message-ID: e08cc0400811070746p43553f10s6bb09e98b7eafc3b@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
David, Vladimir,

2008/11/5 Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>:
> Now my assumption is broken. Let me take time to think about how to solve it...

I fixed the points we discussed a few days ago. The delta is here:

http://git.postgresql.org/?p=~davidfetter/window_functions/.git;a=commitdiff;h=bfbc039f68aa749b403c84a803d49a02b3d6c199;hp=bbba638f721a7e1d11cb3ee6af3bc1d7d3c11aa8

although attached is the whole (split) patch.

In addition to fixing cume_dist() and implicit frame definition, I
added two window function APIs, WinRowIsPeer() and WinIterFinish(). Up
to now I've avoided to touch ORDER BY clause comparisons deeply,
because I didn't see any abstraction in that except rank(). But now I
know the very important word "peers" appears so many times in the
spec, I'm inclined to implement some general mechanisms for those APIs
like IsPeer(). Also, as with this version part of RANGE is supported,
the road to the FRAME clause support got shorter than before.

Thanks for your feedback and continuing tests!

Regards,


--
Hitoshi Harada

Attachment: window_functions.patch.20081107-1.gz
Description: application/x-gzip (46.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Hitoshi HaradaDate: 2008-11-07 15:47:22
Subject: Re: Windowing Function Patch Review -> Standard Conformance
Previous:From: Alvaro HerreraDate: 2008-11-07 15:42:16
Subject: restore PD_PAGE_FULL on WAL update replay

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group