Skip site navigation (1) Skip section navigation (2)

Re: Fix overflow of bgwriter's request queue

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix overflow of bgwriter's request queue
Date: 2006-01-13 22:09:50
Message-ID: dq98d1$1mp$1@news.hub.org (view raw or flat)
Thread:
Lists: pgsql-patches
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>
> Yes, the patch is wrong as-is because it may lose uncompleted fsyncs.
> But I think that we could just add the AbsorbFsyncRequests call in the
> fsync loop and not worry about trying to avoid doing extra fsyncs.
>
> Another possibility is to make the copied list as in the patch, but
> HASH_REMOVE an entry only after doing the fsync successfully --- as long
> as you don't AbsorbFsyncRequests between doing the fsync and removing
> the entry, you aren't risking missing a necessary fsync.  I'm
> unconvinced that this is worth the trouble, however.
>

Maybe the take a copied list is safer. I got a little afraid of doing 
seqscan hash while doing HASH_ENTER at the same time. Do we have this kind 
of hash usage somewhere?

Regards,
Qingqing 



In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2006-01-13 22:20:14
Subject: Re: Fix overflow of bgwriter's request queue
Previous:From: Tom LaneDate: 2006-01-13 21:05:52
Subject: Re: Fix overflow of bgwriter's request queue

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group