Skip site navigation (1) Skip section navigation (2)

Re: Fix spinlock usage in UnpinBuffer()

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix spinlock usage in UnpinBuffer()
Date: 2005-12-29 19:18:16
Message-ID: dp1cnk$h7p$1@news.hub.org (view raw or flat)
Thread:
Lists: pgsql-patches
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>
> I noticed that shmem.c holds ShmemIndexLock considerably longer than any
> other spinlock is held, and across operations that could theoretically
> fail (hashtable manipulations).  This doesn't matter a lot in the Unix
> code because only the postmaster ever executes ShmemInitStruct, but
> in the Windows port we run that code every time a backend is launched.
> I think that we could convert that spinlock to an LWLock.  Will look into 
> it.
>

Yeah, use LWLock is a safer way in order to recover to unlock status.

Regards,
Qingqing 



In response to

pgsql-patches by date

Next:From: Neil ConwayDate: 2005-12-29 21:56:12
Subject: Re: pl/python: fix ref leak on elog
Previous:From: Tom LaneDate: 2005-12-29 18:44:43
Subject: Re: pl/python: fix ref leak on elog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group