Re: [PATCHES] snprintf() argument reordering not working under Windows in 8.1

From: Nicolai Tufar <ntufar(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, devrim(at)kivi(dot)com(dot)tr, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] snprintf() argument reordering not working under Windows in 8.1
Date: 2005-12-06 08:52:24
Message-ID: d80929390512060052i1a9982c4i@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

2005/12/4, Andrew Dunstan <andrew(at)dunslane(dot)net>:
> Tom said:
>
> >Would it work to modify c.h so that it #include's libintl.h, then #undefs
> >these macros, then #includes port.h to define 'em the way we want?
> >Some or all of this might need to be #ifdef WIN32, but that seems like
> >a reasonably noninvasive solution if it can work.
> >
>
> IIRC last time I tried this it didn't work too well ;-( I will have
> another go. I think it's the best way to go.

Very well, I will try to put up a patch to implement it in a couple of days.

>
> cheers
>
> andrew
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicolai Tufar 2005-12-06 08:59:08 Re: [PATCHES] snprintf() argument reordering not working under Windows in 8.1
Previous Message Michael Fuhr 2005-12-06 08:15:08 Re: inet to bigint?

Browse pgsql-patches by date

  From Date Subject
Next Message Nicolai Tufar 2005-12-06 08:59:08 Re: [PATCHES] snprintf() argument reordering not working under Windows in 8.1
Previous Message Tom Lane 2005-12-06 06:02:40 Re: Reduce NUMERIC size by 2 bytes, reduce max length to 508