Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] snprintf causes regression tests to fail

From: Nicolai Tufar <ntufar(at)gmail(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Date: 2005-03-12 15:00:14
Message-ID: d809293905031207005ec9216c@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Resubmission of yesterday's patch so that it would
cont conflict with Bruce's cvs commit. Pleas apply.

Best regards,
Nicolai.


On Sat, 12 Mar 2005 01:58:15 +0200, Nicolai Tufar <ntufar(at)gmail(dot)com> wrote:
> On Thu, 10 Mar 2005 19:21:41 -0500 (EST), Bruce Momjian
> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > > The CVS-tip implementation is fundamentally broken and won't work even
> > > for our internal uses.  I've not wasted time complaining about it
> > > because I thought we were going to replace it.  If we can't find a
> > > usable replacement then we're going to have to put a lot of effort
> > > into fixing what's there.  On the whole I think the effort would be
> > > better spent importing someone else's solution.
> >
> > Oh, so our existing implementation doesn't even meet our needs. OK.
> 
> Which made me wander why did I not aggree with
> Tom Lane's suggestion to make do three passes
> instead of two. Tom was right, as usual. It happened to
> be much easier than I expected. The patch is attached.
> Please apply.
> 
> Tom, what do you think? Will it be fine with you?
> 
> Best regards,
> Nicolai
> 
> 
>

Attachment: snprintf.diff
Description: text/x-patch (6.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Joe ConwayDate: 2005-03-12 15:12:54
Subject: Re: cvsup binaries?
Previous:From: Devrim GUNDUZDate: 2005-03-12 14:28:36
Subject: Re: cvsup binaries?

pgsql-patches by date

Next:From: Neil ConwayDate: 2005-03-12 15:37:55
Subject: Re: Display Pg buffer cache (WIP)
Previous:From: Andrew DunstanDate: 2005-03-12 14:03:16
Subject: Re: pgsql: Handle carriage returns and line feeds in COPY

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2005-03-14 18:55:16
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests
Previous:From: Nicolai TufarDate: 2005-03-11 23:58:15
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group