Skip site navigation (1) Skip section navigation (2)

remove an unused variable waitingForSignal

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-patches(at)postgresql(dot)org
Subject: remove an unused variable waitingForSignal
Date: 2005-04-11 03:10:25
Message-ID: d3cpum$2735$1@news.hub.org (view raw or flat)
Thread:
Lists: pgsql-patches
Remove an unused variable waitingForSignal in /storage/lmgr/proc.c.
I guess it was there because orignally PG uses singals to implement
ProcWaitForSignal() stuff, so we may need to remember the process status.
But now we don't need it.


Index: proc.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/backend/storage/lmgr/proc.c,v
retrieving revision 1.156
diff -c -r1.156 proc.c
*** proc.c      31 Dec 2004 22:01:05 -0000      1.156
--- proc.c      11 Apr 2005 03:08:39 -0000
***************
*** 74,80 ****
  static PGPROC *DummyProcs = NULL;

  static bool waitingForLock = false;
- static bool waitingForSignal = false;

  /* Mark these volatile because they can be changed by signal handler */
  static volatile bool statement_timeout_active = false;
--- 74,79 ----
***************
*** 962,970 ****
  void
  ProcWaitForSignal(void)
  {
-       waitingForSignal = true;
        PGSemaphoreLock(&MyProc->sem, true);
-       waitingForSignal = false;
  }

  /*
--- 961,967 ----
***************
*** 978,984 ****
  ProcCancelWaitForSignal(void)
  {
        PGSemaphoreReset(&MyProc->sem);
-       waitingForSignal = false;
  }

  /*
--- 975,980 ----



Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2005-04-11 05:40:42
Subject: Proof of concept for MIN/MAX optimization
Previous:From: Robert TreatDate: 2005-04-10 04:38:08
Subject: update some urls

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group