| From: | NikhilS <nikkhils(at)gmail(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Neil Conway" <neilc(at)samurai(dot)com>, "Trevor Hardcastle" <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Date: | 2007-05-23 14:39:20 |
| Message-ID: | d3c4af540705230739t1dd4f401jaac86e1c35d8a9ba@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hi,
> I agree this will unnecessary add arguments to the DefineIndex API. If we
> > stick to the patch's earlier way of converting the Oid to names for just
> > these 2 arguments, we can avoid this IMO.
> >
> > Considering that we will be generating this information from existing
> valid
> > index information, I think converting the Oids to names is safe enough.
> > Alvaro, do you think we should stick to the existing patch mechanism
> then
> > considering that it avoids polluting the API?
>
> Not sure. Is it possible that the schema is renamed while the operation
> is being executed? If it's not then this not a problem at all so the
> existing patch is fine.
I doubt if accessMethod name will change. The tableSpace name can change,
but the possibility is no worse to doing a [CREATE TABLE table_name ...
TABLESPACE tablespace]. So this should be reasonably ok.
Regards,
Nikhils
--
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-23 14:41:09 | Re: like/ilike improvements |
| Previous Message | Tom Lane | 2007-05-23 14:38:53 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-23 14:41:09 | Re: like/ilike improvements |
| Previous Message | Tom Lane | 2007-05-23 14:38:53 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |