Skip site navigation (1) Skip section navigation (2)

Re: CREATE TABLE LIKE INCLUDING INDEXES support

From: NikhilS <nikkhils(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Neil Conway" <neilc(at)samurai(dot)com>, "Trevor Hardcastle" <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date: 2007-05-23 14:08:33
Message-ID: d3c4af540705230708r942c8a5qe0e4596b23009910@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Hi,

On 5/23/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> NikhilS <nikkhils(at)gmail(dot)com> writes:
> > If so, I think we can introduce 2 Oid fields in the IndexStmt structure
> and
> > store the Oids there. In DefineIndex we can use these Oids if they are
> not
> > invalid.
>
> I think this is just make-work that causes the patch to complicate parts
> of the system it didn't need to touch.  The original suggestion was to
> actively refactor existing code, which might or might not have been
> worthwhile.  But this isn't an appropriate substitute --- it's just
> making the API uglier for no particular benefit.


I agree this will unnecessary add arguments to the DefineIndex API. If we
stick to the patch's earlier way of converting the Oid to names for just
these 2 arguments, we can avoid this IMO.

Considering that we will be generating this information from existing valid
index information, I think converting the Oids to names is safe enough.
Alvaro, do you think we should stick to the existing patch mechanism then
considering that it avoids polluting the API?

Regards,
Nikhils
-- 
EnterpriseDB               http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-05-23 14:11:56
Subject: Re: Re: [Oledb-dev] double precision error with pg linux server, but not with windows pg server
Previous:From: Tom LaneDate: 2007-05-23 13:59:12
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2007-05-23 14:24:42
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous:From: Tom LaneDate: 2007-05-23 13:59:12
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group