Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] psql 'none' as a HISTFILE special case

From: "Martin Atukunda" <matlads(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] psql 'none' as a HISTFILE special case
Date: 2006-08-25 17:20:34
Message-ID: ce92d7150608251020t71f06341oce1d2cd13f7a5f45@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On 8/25/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > When I set HISTFILE to /dev/null I get the following:
> > could not save history to file "/dev/null": Operation not permitted
>
> Hm.  ktrace shows this happening:
>
>  23279 psql     CALL  open(0x302d70,0x601,0x1b6)
>  23279 psql     NAMI  "/dev/null"
>  23279 psql     RET   open 3
>  23279 psql     CALL  fchmod(0x3,0x180)
>  23279 psql     RET   fchmod -1 errno 1 Operation not permitted
>  23279 psql     CALL  close(0x3)
>  23279 psql     RET   close 0
>  23279 psql     CALL  write(0x2,0xbffff180,0x44)
>  23279 psql     GIO   fd 2 wrote 68 bytes
>        "could not save history to file "/dev/null": Operation not permitted
>        "
>  23279 psql     RET   write 68/0x44
>  23279 psql     CALL  exit(0)
>
> There's probably no way to get Apple's libedit to not try the fchmod,
> so what do we want to do here?  Maybe special-case the string
> "/dev/null"?

If this is OK, I can up with a patch that special cases /dev/null as a
HISTFILE if libedit is found.

- Martin -

In response to

Responses

pgsql-hackers by date

Next:From: Bort, PaulDate: 2006-08-25 17:22:28
Subject: Re: [Pgsqlrpms-hackers] Safer auto-initdb for RPM init
Previous:From: Jeff DavisDate: 2006-08-25 16:31:55
Subject: Re: Replication

pgsql-patches by date

Next:From: Zoltan BoszormenyiDate: 2006-08-25 17:37:34
Subject: Re: Performance testing of COPY (SELECT) TO
Previous:From: Tom LaneDate: 2006-08-25 16:28:16
Subject: Re: [HACKERS] psql 'none' as a HISTFILE special case

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group