Skip site navigation (1) Skip section navigation (2)

Re: remove unused "caller" arg from stringToQualifiedNameList

From: "Jaime Casanova" <systemguards(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: remove unused "caller" arg from stringToQualifiedNameList
Date: 2007-06-26 01:11:19
Message-ID: c2d9e70e0706251811o3fe67a9ft91aea2c62a26154e@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-patches
On 6/25/07, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > > This function seems to have an argument that is no longer used (probably
> > > leftover from when it used to report an error message?).
> >
> > Yeah, I recall having left the argument in place because it seemed like
> > we might want it again someday.  But that was for 7.4 which was awhile
> > ago.  There's probably not a strong argument to keep it, but on the
> > other hand is there a strong argument to remove it?
>
> Other than removing cruft, nope, I don't see any ...
>
> In any case, this is an exported symbol so maybe it's not a good idea to
> mess with it.  OTOH I checked PL/R and PL/php and neither uses it, so
> this may not be a problem at all.
>

FWIW, we remove the second argument in textToQualifiedNameList() two
years ago so i think this is just finishing what we already started,
IMHO anyway
http://archives.postgresql.org/pgsql-committers/2005-05/msg00318.php

-- 
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
                                       Richard Cook

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2007-06-26 04:08:49
Subject: Re: remove unused "caller" arg from stringToQualifiedNameList
Previous:From: Tom LaneDate: 2007-06-25 23:52:22
Subject: Re: Maintaining cluster order on insert

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group